netdev - RE: [Intel-wired-lan] [PATCH intel-net] ice: fix napi work done reporting in xsk path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 12:06:36 +0000
From:   "Bhandare, KiranX" <kiranx.bhandare@...el.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Topel, Bjorn" <bjorn.topel@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "maciejromanfijalkowski@...il.com" <maciejromanfijalkowski@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH intel-net] ice: fix napi work done
 reporting in xsk path

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Magnus Karlsson
> Sent: Friday, February 5, 2021 2:39 PM
> To: Karlsson, Magnus <magnus.karlsson@...el.com>; Topel, Bjorn
> <bjorn.topel@...el.com>; intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony
> L <anthony.l.nguyen@...el.com>; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; maciejromanfijalkowski@...il.com
> Cc: netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH intel-net] ice: fix napi work done reporting
> in xsk path
> 
> From: Magnus Karlsson <magnus.karlsson@...el.com>
> 
> Fix the wrong napi work done reporting in the xsk path of the ice driver. The
> code in the main Rx processing loop was written to assume that the buffer
> allocation code returns true if all allocations where successful and false if
> not. In contrast with all other Intel NIC xsk drivers, the ice_alloc_rx_bufs_zc()
> has the inverted logic messing up the work done reporting in the napi loop.
> 
> This can be fixed either by inverting the return value from
> ice_alloc_rx_bufs_zc() in the function that uses this in an incorrect way, or by
> changing the return value of ice_alloc_rx_bufs_zc(). We chose the latter as it
> makes all the xsk allocation functions for Intel NICs behave in the same way.
> My guess is that it was this unexpected discrepancy that gave rise to this bug
> in the first place.
> 
> Fixes: 5bb0c4b5eb61 ("ice, xsk: Move Rx allocation out of while-loop")
> Reported-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_base.c |  6 ++++--
> drivers/net/ethernet/intel/ice/ice_xsk.c  | 10 +++++-----
>  2 files changed, 9 insertions(+), 7 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@...el.com>  A Contingent Worker at Intel