[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87k0qditsu.fsf@nvidia.com>
Date: Thu, 11 Mar 2021 16:39:13 +0100
From: Petr Machata <petrm@...dia.com>
To: David Ahern <dsahern@...il.com>
CC: Petr Machata <petrm@...dia.com>, <netdev@...r.kernel.org>,
Ido Schimmel <idosch@...dia.com>,
David Ahern <dsahern@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 03/14] nexthop: Add a dedicated flag for
multipath next-hop groups
David Ahern <dsahern@...il.com> writes:
>> diff --git a/include/net/nexthop.h b/include/net/nexthop.h
>> index 7bc057aee40b..5062c2c08e2b 100644
>> --- a/include/net/nexthop.h
>> +++ b/include/net/nexthop.h
>> @@ -80,6 +80,7 @@ struct nh_grp_entry {
>> struct nh_group {
>> struct nh_group *spare; /* spare group for removals */
>> u16 num_nh;
>> + bool is_multipath;
>> bool mpath;
>
>
> It would be good to rename the existing type 'mpath' to something else.
> You have 'resilient' as a group type later, so maybe rename this one to
> hash or hash_threshold.
All right, I'll send a follow-up with that.
Powered by blists - more mailing lists