[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210311152910.56760-16-maciej.fijalkowski@intel.com>
Date: Thu, 11 Mar 2021 16:29:08 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: bpf@...r.kernel.org, netdev@...r.kernel.org, daniel@...earbox.net,
ast@...nel.org
Cc: bjorn.topel@...el.com, magnus.karlsson@...el.com,
ciara.loftus@...el.com, john.fastabend@...il.com, toke@...hat.com
Subject: [PATCH v2 bpf-next 15/17] selftests: xsk: remove thread attribute
From: Björn Töpel <bjorn.topel@...el.com>
There is really no reason to have a non-default thread stack
size. Remove that.
Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
---
tools/testing/selftests/bpf/xdpxceiver.c | 9 ++-------
tools/testing/selftests/bpf/xdpxceiver.h | 2 --
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
index dc775ee139c5..35826d73266f 100644
--- a/tools/testing/selftests/bpf/xdpxceiver.c
+++ b/tools/testing/selftests/bpf/xdpxceiver.c
@@ -765,8 +765,6 @@ static void thread_common_ops(struct ifobject *ifobject, void *bufs)
int ctr = 0;
int ret;
- pthread_attr_setstacksize(&attr, THREAD_STACK);
-
ifobject->ns_fd = switch_namespace(ifobject->nsname);
if (test_type == TEST_TYPE_BPF_RES)
@@ -910,13 +908,10 @@ static void testapp_validate(void)
bool bidi = test_type == TEST_TYPE_BIDI;
bool bpf = test_type == TEST_TYPE_BPF_RES;
- pthread_attr_init(&attr);
- pthread_attr_setstacksize(&attr, THREAD_STACK);
-
pthread_mutex_lock(&sync_mutex);
/*Spawn RX thread */
- pthread_create(&t0, &attr, ifdict_rx->func_ptr, ifdict_rx);
+ pthread_create(&t0, NULL, ifdict_rx->func_ptr, ifdict_rx);
if (clock_gettime(CLOCK_REALTIME, &max_wait))
exit_with_error(errno);
@@ -928,7 +923,7 @@ static void testapp_validate(void)
pthread_mutex_unlock(&sync_mutex);
/*Spawn TX thread */
- pthread_create(&t1, &attr, ifdict_tx->func_ptr, ifdict_tx);
+ pthread_create(&t1, NULL, ifdict_tx->func_ptr, ifdict_tx);
pthread_join(t1, NULL);
pthread_join(t0, NULL);
diff --git a/tools/testing/selftests/bpf/xdpxceiver.h b/tools/testing/selftests/bpf/xdpxceiver.h
index 302cb66f8c57..09b85a2925a5 100644
--- a/tools/testing/selftests/bpf/xdpxceiver.h
+++ b/tools/testing/selftests/bpf/xdpxceiver.h
@@ -37,7 +37,6 @@
#define TMOUT_SEC (3)
#define EOT (-1)
#define USLEEP_MAX 200000
-#define THREAD_STACK 60000000
#define SOCK_RECONF_CTR 10
#define BATCH_SIZE 64
#define POLL_TMOUT 1000
@@ -152,7 +151,6 @@ static struct ifobject *ifdict_tx;
pthread_mutex_t sync_mutex;
pthread_cond_t signal_rx_condition;
pthread_t t0, t1;
-pthread_attr_t attr;
TAILQ_HEAD(head_s, pkt) head = TAILQ_HEAD_INITIALIZER(head);
struct head_s *head_p;
--
2.20.1
Powered by blists - more mailing lists