[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210311164711.GA892053@BV030612LT>
Date: Thu, 11 Mar 2021 18:47:11 +0200
From: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
To: Philipp Zabel <pza@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Andreas Färber <afaerber@...e.de>,
Manivannan Sadhasivam <mani@...nel.org>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl
Ethernet MAC driver
Hi Philipp,
Thanks for your quick review!
I will incorporate the indicated changes in the next patch revision.
Kind regards,
Cristi
On Thu, Mar 11, 2021 at 07:43:36AM +0100, Philipp Zabel wrote:
> Hi Cristian,
>
> On Thu, Mar 11, 2021 at 03:20:13AM +0200, Cristian Ciocaltea wrote:
> > Add new driver for the Ethernet MAC used on the Actions Semi Owl
> > family of SoCs.
> >
> > Currently this has been tested only on the Actions Semi S500 SoC
> > variant.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
> > ---
> [...]
> > diff --git a/drivers/net/ethernet/actions/owl-emac.c b/drivers/net/ethernet/actions/owl-emac.c
> > new file mode 100644
> > index 000000000000..ebd8ea88bca4
> > --- /dev/null
> > +++ b/drivers/net/ethernet/actions/owl-emac.c
> > @@ -0,0 +1,1660 @@
> [...]
> > +static int owl_emac_probe(struct platform_device *pdev)
> > +{
> [...]
> > + priv->reset = devm_reset_control_get(dev, NULL);
>
> Please use
>
> priv->reset = devm_reset_control_get_exclusive(dev, NULL);
>
> instead, to explicitly state that the driver requires exclusive
> control over the reset line.
>
> > + if (IS_ERR(priv->reset)) {
> > + ret = PTR_ERR(priv->reset);
> > + dev_err(dev, "failed to get reset control: %d\n", ret);
> > + return ret;
>
> You could use:
>
> return dev_err_probe(dev, PTR_ERR(priv->reset),
> "failed to get reset control");
>
> regards
> Philipp
Powered by blists - more mailing lists