netdev - Re: of_mdio: Checking build dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Mar 2021 02:24:52 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Markus Elfring <Markus.Elfring@....de>,
        stable <stable@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Calvin Johnson <calvin.johnson@....nxp.com>,
        "David S. Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: of_mdio: Checking build dependencies

On Fri, Mar 12, 2021 at 1:26 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Mar 10, 2021 at 09:31:07PM +0100, Markus Elfring wrote:
> > Hello,
> >
> > I would like to build the Linux version “5.11.5” for my needs.
> > But I stumbled on the following information.
> >
> > …
> >   AR      drivers/built-in.a
> >   LD [M]  drivers/visorbus/visorbus.o
> >   GEN     .version
> >   CHK     include/generated/compile.h
> > error: the following would cause module name conflict:
> >   drivers/net/mdio/of_mdio.ko
> >   drivers/of/of_mdio.ko
>
> Hi Markus
>
> Something wrong here. There should not be any of_mdio.ko in
> drivers/of. That was the whole point of the patch you referenced, it
> moved this file to drivers/net/mdio/. Please check where your
> drivers/of/of_mdio.ko comes from. Has there been a bad merge conflict
> resolution? Or is it left over from an older build?
>
>    Andrew


modules.order may include both
drivers/of/of_mdio.ko  and
drivers/net/mdio/of_mdio.c

But, I do not know how this could happen.

I checked out 14b26b127c098bba^,
and built modules with CONFIG_OF_MDIO=m.
Then, I checked out 14b26b127c098bba
and rebuilt.

I did not see such an error.

I also checked the Kbuild code,
and it looks good too.

Please let me know if you find steps
to reproduce it.

--
Best Regards
Masahiro Yamada