[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210311123229.00007580@intel.com>
Date: Thu, 11 Mar 2021 12:32:29 -0800
From: Jesse Brandeburg <jesse.brandeburg@...el.com>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: "kuba@...nel.org" <kuba@...nel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
"simon.horman@...ronome.com" <simon.horman@...ronome.com>,
"yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
"salil.mehta@...wei.com" <salil.mehta@...wei.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
"drivers@...sando.io" <drivers@...sando.io>,
"snelson@...sando.io" <snelson@...sando.io>,
"netanel@...zon.com" <netanel@...zon.com>,
"akiyano@...zon.com" <akiyano@...zon.com>,
"gtzalik@...zon.com" <gtzalik@...zon.com>,
"saeedb@...zon.com" <saeedb@...zon.com>,
"GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
"skalluru@...vell.com" <skalluru@...vell.com>,
"rmody@...vell.com" <rmody@...vell.com>,
"kys@...rosoft.com" <kys@...rosoft.com>,
"haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
"sthemmin@...rosoft.com" <sthemmin@...rosoft.com>,
"wei.liu@...nel.org" <wei.liu@...nel.org>,
"mst@...hat.com" <mst@...hat.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"pv-drivers@...are.com" <pv-drivers@...are.com>,
"doshir@...are.com" <doshir@...are.com>,
"alexanderduyck@...com" <alexanderduyck@...com>
Subject: Re: [RFC PATCH 02/10] intel: Update drivers to use ethtool_gsprintf
Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@...com>
>
> Update the Intel drivers to make use of ethtool_gsprintf. The general idea
> is to reduce code size and overhead by replacing the repeated pattern of
> string printf statements and ETH_STRING_LEN counter increments.
>
> Signed-off-by: Alexander Duyck <alexanderduyck@...com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 16 ++----
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 55 +++++++---------------
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 40 ++++++----------
> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 40 ++++++----------
> 4 files changed, 50 insertions(+), 101 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index c70dec65a572..932c6635cfd6 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -2368,21 +2368,15 @@ static void i40e_get_priv_flag_strings(struct net_device *netdev, u8 *data)
> struct i40e_netdev_priv *np = netdev_priv(netdev);
> struct i40e_vsi *vsi = np->vsi;
> struct i40e_pf *pf = vsi->back;
> - char *p = (char *)data;
> + u8 *p = data;
> unsigned int i;
As Jakub said, RCT... :-)
no other comments on the rest of the patch, looks good and Thanks!
Powered by blists - more mailing lists