lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ac6955443a4aa5d0a72e6f2bf15c494f36b78f5c.camel@kernel.org>
Date:   Thu, 11 Mar 2021 14:48:23 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Roi Dayan <roid@...dia.com>, Arnd Bergmann <arnd@...nel.org>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Dmytro Linkin <dlinkin@...dia.com>,
        Vlad Buslov <vladbu@...dia.com>
Cc:     Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: include net/nexthop.h where needed

On Mon, 2021-03-08 at 20:23 +0200, Roi Dayan wrote:
> 
> 
> On 2021-03-08 5:31 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12:
> > error: implicit declaration of function 'fib_info_nh' [-Werror,-
> > Wimplicit-function-declaration]
> >          fib_dev = fib_info_nh(fen_info->fi, 0)->fib_nh_dev;
> >                    ^
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12:
> > note: did you mean 'fib_info_put'?
> > include/net/ip_fib.h:529:20: note: 'fib_info_put' declared here
> > static inline void fib_info_put(struct fib_info *fi)
> >                     ^
> > 
> > Fixes: 8914add2c9e5 ("net/mlx5e: Handle FIB events to update tunnel
> > endpoint device")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >   drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > index 6a116335bb21..32d06fe94acc 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c
> > @@ -2,6 +2,7 @@
> >   /* Copyright (c) 2021 Mellanox Technologies. */
> >   
> >   #include <net/fib_notifier.h>
> > +#include <net/nexthop.h>
> >   #include "tc_tun_encap.h"
> >   #include "en_tc.h"
> >   #include "tc_tun.h"
> > 
> 
> Hi,
> 
> I see internally we have a pending commit from Vlad fixing this
> already,
> with few more fixes. "net/mlx5e: Add missing include"
> 
> I'll check why it's being held.

Just submitted to net-next. 
Thanks!


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ