[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210311033323.191873-1-hoang.h.le@dektech.com.au>
Date: Thu, 11 Mar 2021 10:33:22 +0700
From: Hoang Huu Le <hoang.h.le@...tech.com.au>
To: jmaloy@...hat.com, maloy@...jonn.com, ying.xue@...driver.com,
kuba@...nel.org, netdev@...r.kernel.org,
tipc-discussion@...ts.sourceforge.net
Cc: Hoang Le <hoang.h.le@...tech.com.au>
Subject: [net-next 1/2] tipc: convert dest node's address to network order
From: Hoang Le <hoang.h.le@...tech.com.au>
(struct tipc_link_info)->dest is in network order (__be32), so we must
convert the value to network order before assigning. The problem detected
by sparse:
net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)
net/tipc/netlink_compat.c:699:24: expected restricted __be32 [usertype] dest
net/tipc/netlink_compat.c:699:24: got int
Acked-by: Jon Maloy <jmaloy@...hat.com>
Signed-off-by: Hoang Le <hoang.h.le@...tech.com.au>
---
net/tipc/netlink_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index 5a1ce64039f7..0749df80454d 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -696,7 +696,7 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg,
if (err)
return err;
- link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]);
+ link_info.dest = htonl(nla_get_flag(link[TIPC_NLA_LINK_DEST]));
link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP]));
nla_strscpy(link_info.str, link[TIPC_NLA_LINK_NAME],
TIPC_MAX_LINK_NAME);
--
2.25.1
Powered by blists - more mailing lists