netdev - Re: [PATCH] net: core: Few absolutely rudimentary typo fixes throughout the file filter.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <786f4801-c41f-cddd-c855-b388ec026614@infradead.org>
Date:   Wed, 10 Mar 2021 22:12:43 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, davem@...emloft.net, kuba@...nel.org,
        hawk@...nel.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: core: Few absolutely rudimentary typo fixes
 throughout the file filter.c

On 3/10/21 9:56 PM, Bhaskar Chowdhury wrote:
> 
> Trivial spelling fixes throughout the file.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>

Hi Bhaskar,

FYI:

a. we accept British or American spellings
b. we accept one or two spaces after a period ('.') at the end of a sentence
c. we accept Oxford (serial) comma or not

> ---
>  net/core/filter.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 255aeee72402..931ee5f39ae7 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2927,7 +2927,7 @@ BPF_CALL_4(bpf_msg_pop_data, struct sk_msg *, msg, u32, start,
>  	 *
>  	 * Then if B is non-zero AND there is no space allocate space and
>  	 * compact A, B regions into page. If there is space shift ring to
> -	 * the rigth free'ing the next element in ring to place B, leaving
> +	 * the right freeing the next element in ring to place B, leaving
>  	 * A untouched except to reduce length.
>  	 */
>  	if (start != offset) {
> @@ -3710,7 +3710,7 @@ static inline int __bpf_skb_change_tail(struct sk_buff *skb, u32 new_len,
>  	 * be the one responsible for writing buffers.
>  	 *
>  	 * It's really expected to be a slow path operation here for
> -	 * control message replies, so we're implicitly linearizing,
> +	 * control message replies, so we're implicitly linearising,
>  	 * uncloning and drop offloads from the skb by this.
>  	 */
>  	ret = __bpf_try_make_writable(skb, skb->len);
> @@ -3778,7 +3778,7 @@ static inline int __bpf_skb_change_head(struct sk_buff *skb, u32 head_room,
>  		 * allow to expand on mac header. This means that
>  		 * skb->protocol network header, etc, stay as is.
>  		 * Compared to bpf_skb_change_tail(), we're more
> -		 * flexible due to not needing to linearize or
> +		 * flexible due to not needing to linearise or
>  		 * reset GSO. Intention for this helper is to be
>  		 * used by an L3 skb that needs to push mac header
>  		 * for redirection into L2 device.
> --


-- 
~Randy