netdev - Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUcZxsL7cKoSGFbHtei+ad6j2xWyJzviOoOcGH6jGxisw@mail.gmail.com>
Date:   Thu, 11 Mar 2021 16:45:05 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg

On Thu, Mar 11, 2021 at 3:28 AM Jakub Sitnicki <jakub@...udflare.com> wrote:
> > +
> > +static inline struct sk_msg *sk_psock_deque_msg(struct sk_psock *psock)
>
> Should be sk_psock_deque*ue*_msg()?

Right, it is better and less confusing to use "dequeue".

Thanks.