netdev - Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210314.143101.1456394019713348728.davem@davemloft.net>
Date:   Sun, 14 Mar 2021 14:31:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladimir.oltean@....com
Cc:     jakub@...udflare.com, alobakin@...me, kuba@...nel.org,
        ast@...nel.org, andriin@...com, dcaratti@...hat.com,
        gnault@...hat.com, wenxu@...oud.cn, eranbe@...dia.com,
        mcroce@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

From: Vladimir Oltean <vladimir.oltean@....com>
Date: Sun, 14 Mar 2021 20:44:49 +0000

> On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote:
>> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote:
>> 
>> Smells like a breaking change for existing consumers of this value.
>> 
>> How about we change the type of flow_dissector_key_icmp{}.id to __be16
>> instead to make sparse happy?
> 
> The struct flow_dissector_key_icmp::id only appears to be used in
> bond_xmit_hash, and there, the exact value doesn't seem to matter.
> 
> This appears to be a real bug and not just to appease sparse:
> ih->un.echo.id has one endianness and "1" has another. Both cannot
> be correct.

Agreed, so I will apply this, thanks.