netdev - Re: [PATCH iproute2-next 4/6] nexthop: Add ability to specify group type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5397a5b8-da46-7290-9395-5fcd46121f42@gmail.com>
Date:   Sun, 14 Mar 2021 09:55:45 -0600
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org,
        stephen@...workplumber.org
Cc:     Ido Schimmel <idosch@...dia.com>, Petr Machata <me@...chata.org>
Subject: Re: [PATCH iproute2-next 4/6] nexthop: Add ability to specify group
 type

On 3/12/21 10:23 AM, Petr Machata wrote:
> From: Petr Machata <me@...chata.org>
> 
> From: Ido Schimmel <idosch@...dia.com>

All of the patches have the above. If Ido is the author and you are
sending, AIUI you add your Signed-off-by below his.

> 
> Next patches are going to add a 'resilient' nexthop group type, so allow
> users to specify the type using the 'type' argument. Currently, only
> 'mpath' type is supported.
> 
> These two command are equivalent:
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  ip/ipnexthop.c        | 32 +++++++++++++++++++++++++++++++-
>  man/man8/ip-nexthop.8 | 18 ++++++++++++++++--
>  2 files changed, 47 insertions(+), 3 deletions(-)
> 

...

> diff --git a/man/man8/ip-nexthop.8 b/man/man8/ip-nexthop.8
> index 4d55f4dbcc75..f02e0555a000 100644
> --- a/man/man8/ip-nexthop.8
> +++ b/man/man8/ip-nexthop.8
> @@ -54,7 +54,9 @@ ip-nexthop \- nexthop object management
>  .BR fdb " ] | "
>  .B  group
>  .IR GROUP " [ "
> -.BR fdb " ] } "
> +.BR fdb " ] [ "
> +.B type
> +.IR TYPE " ] } "
>  
>  .ti -8
>  .IR ENCAP " := [ "
> @@ -71,6 +73,10 @@ ip-nexthop \- nexthop object management
>  .IR GROUP " := "
>  .BR id "[," weight "[/...]"
>  
> +.ti -8
> +.IR TYPE " := { "
> +.BR mpath " }"
> +
>  .SH DESCRIPTION
>  .B ip nexthop
>  is used to manipulate entries in the kernel's nexthop tables.
> @@ -122,9 +128,17 @@ is a set of encapsulation attributes specific to the
>  .in -2
>  
>  .TP
> -.BI group " GROUP"
> +.BI group " GROUP [ " type " TYPE ]"
>  create a nexthop group. Group specification is id with an optional
>  weight (id,weight) and a '/' as a separator between entries.
> +.sp
> +.I TYPE
> +is a string specifying the nexthop group type. Namely:
> +
> +.in +8
> +.BI mpath
> +- multipath nexthop group
> +

Add a comment that this is the default group type and refers to the
legacy hash-bashed multipath group.

The rest of the patches look ok to me.