netdev - [PATCH net-next 2/3] iwlwifi: switch "index larger than supported by driver" warning to debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Mar 2021 20:42:18 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Luca Coelho <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linux-wireless <linux-wireless@...r.kernel.org>
Subject: [PATCH net-next 2/3] iwlwifi: switch "index larger than supported by
 driver" warning to debug level

If a chip supports additional API calls that are not supported by the
driver yet, then this is no reason to bother users with a warning.
Therefore switch the message to debug level.

Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index eb168dc53..647f8d003 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -408,9 +408,8 @@ static void iwl_set_ucode_api_flags(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_API, 32)) {
-		IWL_WARN(drv,
-			 "api flags index %d larger than supported by driver\n",
-			 api_index);
+		IWL_DEBUG_FW_INFO(drv, "api flags index %d larger than supported by driver\n",
+				  api_index);
 		return;
 	}
 
@@ -429,9 +428,8 @@ static void iwl_set_ucode_capabilities(struct iwl_drv *drv, const u8 *data,
 	int i;
 
 	if (api_index >= DIV_ROUND_UP(NUM_IWL_UCODE_TLV_CAPA, 32)) {
-		IWL_WARN(drv,
-			 "capa flags index %d larger than supported by driver\n",
-			 api_index);
+		IWL_DEBUG_FW_INFO(drv, "capa flags index %d larger than supported by driver\n",
+				  api_index);
 		return;
 	}
 
-- 
2.30.2