netdev - Re: [PATCH net-next] net: bridge: mcast: remove unreachable EHT code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad95c2f3-a3c8-cd56-1e83-e4a7d53c7f7f@nvidia.com>
Date:   Mon, 15 Mar 2021 17:44:19 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc:     roopa@...dia.com, bridge@...ts.linux-foundation.org,
        kuba@...nel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] net: bridge: mcast: remove unreachable EHT code

On 15/03/2021 17:38, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@...dia.com>
> 
> In the initial EHT versions there were common functions which handled
> allow/block messages for both INCLUDE and EXCLUDE modes, but later they
> were separated. It seems I've left some common code which cannot be
> reached because the filter mode is checked before calling the respective
> functions, i.e. the host filter is always in EXCLUDE mode when using
> __eht_allow_excl() and __eht_block_excl() thus we can drop the host_excl
> checks inside and simplify the code a bit.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...dia.com>
> ---
>  net/bridge/br_multicast_eht.c | 54 ++++++++++-------------------------
>  1 file changed, 15 insertions(+), 39 deletions(-)
> 

Oh well, sent the wrong patch version. I'll send the proper version as v2.
Self-NAK and sorry for the noise