netdev - Re: [PATCH net] selftests/bpf: set gopt opt_class to 0 if get tunnel opt failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8900191d-fa04-6aaa-f214-92e4cad338a9@iogearbox.net>
Date:   Mon, 15 Mar 2021 17:32:36 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Yi-Hung Wei <yihung.wei@...il.com>,
        David Miller <davem@...emloft.net>, bpf@...r.kernel.org,
        William Tu <u9012063@...il.com>
Subject: Re: [PATCH net] selftests/bpf: set gopt opt_class to 0 if get tunnel
 opt failed

On 3/15/21 7:57 AM, Hangbin Liu wrote:
> On Fri, Mar 12, 2021 at 04:15:27PM +0100, Daniel Borkmann wrote:
>> On 3/12/21 2:56 AM, Hangbin Liu wrote:
>>> Hi David,
>>>
>>> May I ask what's the status of this patch? From patchwork[1] the state is
>>> accepted. But I can't find the fix on net or net-next.
>>
>> I think there may have been two confusions, i) that $subject says that this goes
>> via net tree instead of bpf tree, which might have caused auto-delegation to move
>> this into 'netdev' patchwork reviewer bucket, and ii) the kernel patchwork bot then
>> had a mismatch as you noticed when it checked net-next after tree merge and replied
>> to the wrong patch of yours which then placed this one into 'accepted' state. I just
>> delegated it to bpf and placed it back under review..
>>
>>> [1] https://patchwork.kernel.org/project/netdevbpf/patch/20210309032214.2112438-1-liuhangbin@gmail.com/
> 
> Thanks Daniel, I thought the issue also exists on net tree and is a fixup. So
> I set the target to 'net'.

Sure; in the end this gets routed via bpf to net tree given it's bpf selftests, so
$subj should target bpf. Anyway, applied now, thanks!