[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210315083347.GA28445@lst.de>
Date: Mon, 15 Mar 2021 09:33:47 +0100
From: Christoph Hellwig <hch@....de>
To: Robin Murphy <robin.murphy@....com>
Cc: Christoph Hellwig <hch@....de>, Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>, Li Yang <leoyang.li@....com>,
freedreno@...ts.freedesktop.org, kvm@...r.kernel.org,
Michael Ellerman <mpe@...erman.id.au>,
linuxppc-dev@...ts.ozlabs.org, dri-devel@...ts.freedesktop.org,
virtualization@...ts.linux-foundation.org,
iommu@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-arm-msm@...r.kernel.org,
David Woodhouse <dwmw2@...radead.org>,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 14/17] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE
On Fri, Mar 12, 2021 at 04:18:24PM +0000, Robin Murphy wrote:
>> Let me know what you think of the version here:
>>
>> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/iommu-cleanup
>>
>> I'll happily switch the patch to you as the author if you're fine with
>> that as well.
>
> I still have reservations about removing the attribute API entirely and
> pretending that io_pgtable_cfg is anything other than a SoC-specific
> private interface,
I think a private inteface would make more sense. For now I've just
condensed it down to a generic set of quirk bits and dropped the
attrs structure, which seems like an ok middle ground for now. That
being said I wonder why that quirk isn't simply set in the device
tree?
> but the reworked patch on its own looks reasonable to
> me, thanks! (I wasn't too convinced about the iommu_cmd_line wrappers
> either...) Just iommu_get_dma_strict() needs an export since the SMMU
> drivers can be modular - I consciously didn't add that myself since I was
> mistakenly thinking only iommu-dma would call it.
Fixed. Can I get your signoff for the patch? Then I'll switch it to
over to being attributed to you.
Powered by blists - more mailing lists