netdev - Re: [PATCH v2 net-next 11/12] Documentation: networking: switchdev: clarify device driver behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFC9E44+pB9ZglNt@shredder.lan>
Date:   Tue, 16 Mar 2021 16:13:39 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v2 net-next 11/12] Documentation: networking: switchdev:
 clarify device driver behavior

On Tue, Mar 16, 2021 at 04:04:31PM +0200, Vladimir Oltean wrote:
> On Tue, Mar 16, 2021 at 04:01:13PM +0200, Ido Schimmel wrote:
> > On Tue, Mar 16, 2021 at 01:24:18PM +0200, Vladimir Oltean wrote:
> > > +When the bridge has VLAN filtering enabled and a PVID is not configured on the
> > > +ingress port, untagged 802.1p tagged packets must be dropped. When the bridge
> > 
> > I think you meant "untagged and 802.1p tagged packets" ?
> 
> You're right, I'm missing the "and".
> 
> > Looks good otherwise
> 
> Thanks. I wonder, should I resend the 12 patches, or can I fix up afterwards?

Up to Dave/Jakub. I'm fine with a follow-up.

Reviewed-by: Ido Schimmel <idosch@...dia.com>

Thanks!