netdev - [PATCH] net: ipv6: Fixed some styling issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAPDGunNf5KZjsZVA6BDvt8Nbg_LhbDM_pS9DvjsMQtbqh+Kc-g@mail.gmail.com>
Date:   Tue, 16 Mar 2021 21:33:45 +0530
From:   Anish Udupa <udupa.anish@...il.com>
To:     davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] net: ipv6: Fixed some styling issues.

Ran checkpatch and found some warnings. Fixed some of them in this patch.
a) Added a new line after declarations.
b) Added * before each line in a multi-line comment and made sure that
they are aligned properly.

Signed-off-by: Anish Udupa H <udupa.anish@...il.com>
---
 net/ipv6/icmp.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index fd1f896115c1..57ba852c0944 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -155,6 +155,7 @@ static bool is_ineligible(const struct sk_buff *skb)
  return false;
  if (nexthdr == IPPROTO_ICMPV6) {
  u8 _type, *tp;
+
  tp = skb_header_pointer(skb,
  ptr+offsetof(struct icmp6hdr, icmp6_type),
  sizeof(_type), &_type);
@@ -835,10 +836,10 @@ void icmpv6_notify(struct sk_buff *skb, u8 type,
u8 code, __be32 info)
  goto out;

  /* BUGGG_FUTURE: we should try to parse exthdrs in this packet.
-    Without this we will not able f.e. to make source routed
-    pmtu discovery.
-    Corresponding argument (opt) to notifiers is already added.
-    --ANK (980726)
+ * Without this we will not able f.e. to make source routed
+ * pmtu discovery.
+ * Corresponding argument (opt) to notifiers is already added.
+ * --ANK (980726)
  */

  ipprot = rcu_dereference(inet6_protos[nexthdr]);
@@ -918,9 +919,9 @@ static int icmpv6_rcv(struct sk_buff *skb)

  case ICMPV6_PKT_TOOBIG:
  /* BUGGG_FUTURE: if packet contains rthdr, we cannot update
-    standard destination cache. Seems, only "advanced"
-    destination cache will allow to solve this problem
-    --ANK (980726)
+ * standard destination cache. Seems, only "advanced"
+ * destination cache will allow to solve this problem
+ * --ANK (980726)
  */
  if (!pskb_may_pull(skb, sizeof(struct ipv6hdr)))
  goto discard_it;
-- 
2.17.1