netdev - Re: [PATCH] Fix error message generated in routel script when have 'multicase' in routing list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 23:07:20 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "B.Arenfeld" <b.arenfeld@...or.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] Fix error message generated in routel script when have
 'multicase' in routing list

On Mon, 15 Mar 2021 09:30:07 +0100
"B.Arenfeld" <b.arenfeld@...or.de> wrote:

> Hello :-)
> 
> I'm on an machine with Manjaro Linux. 
> I get some error messages from shift command in the routel script:
> /usr/bin/routel: Zeile 48: shift: shift count out of range
> 
> Reason are lines from "ip route list table 0" starting with word "multicast" :
>  
> multicast ff00::/8 dev enp2s0 table local proto kernel metric 256 pref medium
> 
> I added the "multicast" word in routel script and everything is fine ;-)
> 
> Greetings
> 
> Burkhard Arenfeld
> 
> 
> Signed-off-by: Burkhard Arenfeld <b.arenfeld@...or.de>
> 
> --- routel.orig	2021-03-15 08:23:24.706677247 +0100
> +++ routel	2021-03-15 08:23:20.293589911 +0100
> @@ -25,7 +25,7 @@ ip route list table "$@" |
>      src=""
>      table=""
>      case $network in
> -       broadcast|local|unreachable) via=$network
> +       broadcast|local|multicast|unreachable) via=$network
>            network=$1
>            shift
>            ;;
> 
> 

There are several patches which make it impossible to apply.

Serious: the patch doesn't apply the current version of ip/routel in git
has the same line already there? Not sure where you found the original but
the version in git was imported back in 2015 (from Bitkeeper) and already
has the same line.  Did you get this from some vendor supplied out of date
distro?

Minor: the patch was not based at the normal place in the directory
tree. The standard practice is to do this at directory of the source tree.
In this case it would be in the iproute2 source directory. In that directory
the routel script is in ip sub directory.

Trivial: checkpatch whines that the name in From and Signed-off-by aren't
exact match. But that is just noise, and it looks ok.

Please compare with current iproute2 in git and see if your patch was backwards?