netdev - Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wnu6sjh2.fsf@kokedama.swc.toshiba.co.jp>
Date:   Wed, 17 Mar 2021 09:38:01 +0900
From:   Punit Agrawal <punit1.agrawal@...hiba.co.jp>
To:     Greg KH <greg@...ah.com>
Cc:     stable@...r.kernel.org, netdev@...r.kernel.org,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        daichi1.fukui@...hiba.co.jp, nobuhiro1.iwamatsu@...hiba.co.jp,
        Corinna Vinschen <vinschen@...hat.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Aaron Brown <aaron.f.brown@...el.com>
Subject: Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

Hi Greg,

Greg KH <greg@...ah.com> writes:

> On Thu, Feb 25, 2021 at 09:54:06AM +0900, Punit Agrawal wrote:
>> From: Corinna Vinschen <vinschen@...hat.com>
>> 
>> commit 2643e6e90210e16c978919617170089b7c2164f7 upstream
>> 
>> TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
>> every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
>> secs on 80576 (45 bit SYSTIM).
>> 
>> This wrap event sets the TSICR.SysWrap bit unconditionally.
>> 
>> However, checking TSIM at interrupt time shows that this event does not
>> actually cause the interrupt.  Rather, it's just bycatch while the
>> actual interrupt is caused by, for instance, TSICR.TXTS.
>> 
>> The conclusion is that the SYS WRAP is actually expected, so the
>> "unexpected SYS WRAP" message is entirely bogus and just helps to
>> confuse users.  Drop it.
>> 
>> Signed-off-by: Corinna Vinschen <vinschen@...hat.com>
>> Acked-by: Jacob Keller <jacob.e.keller@...el.com>
>> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> ---
>> [ Due to confusion about stable rules for networking the request was
>> mistakenly sent to netdev only[0]. Apologies if you're seeing this
>> again. ]
>
> No signed-off-by: from you?  :(

Apologies for the missing the SoB. And thank you for applying the patch
to stable even so.

[ Sorry for the long dealy in responding. Our mail system was having
issues (dropping emails randomly) and looks like this mail got caught up
during that period. ]