netdev - Re: [PATCH net-next v17 4/4] net: dsa: mv88e6xxx: implement .port_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210317143255.7vvan6kaclx7w4ys@skbuf>
Date:   Wed, 17 Mar 2021 16:32:55 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, pavana.sharma@...i.com,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        andrew@...n.ch, ashkan.boldaji@...i.com, davem@...emloft.net,
        kuba@...nel.org, f.fainelli@...il.com, vivien.didelot@...il.com,
        lkp@...el.com
Subject: Re: [PATCH net-next v17 4/4] net: dsa: mv88e6xxx: implement
 .port_set_policy for Amethyst

On Wed, Mar 17, 2021 at 02:46:43PM +0100, Marek Behún wrote:
> The 16-bit Port Policy CTL register from older chips is on 6393x changed
> to Port Policy MGMT CTL, which can access more data, but indirectly and
> via 8-bit registers.
> 
> The original 16-bit value is divided into first two 8-bit register in
> the Port Policy MGMT CTL.
> 
> We can therefore use the previous code to compute the mask and shift,
> and then
> - if 0 <= shift < 8, we access register 0 in Port Policy MGMT CTL
> - if 8 <= shift < 16, we access register 1 in Port Policy MGMT CTL
> 
> There are in fact other possible policy settings for Amethyst which
> could be added here, but this can be done in the future.

..and not using ethtool --config-nfc perhaps, but with tc clsact, flower
filters and actions.

> Signed-off-by: Marek Behún <kabel@...nel.org>
> Reviewed-by: Pavana Sharma <pavana.sharma@...i.com>
> ---

I don't have any documentation for 6393x, but the change looks simple
enough.

Reviewed-by: Vladimir Oltean <olteanv@...il.com>