netdev - Re: [PATCH net-next v17 2/4] net: dsa: mv88e6xxx: wrap .set_egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210317144046.vsf2riblq3pms4be@skbuf>
Date:   Wed, 17 Mar 2021 16:40:46 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Marek Behún <marek.behun@....cz>
Cc:     Marek Behún <kabel@...nel.org>,
        netdev@...r.kernel.org, pavana.sharma@...i.com,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        andrew@...n.ch, ashkan.boldaji@...i.com, davem@...emloft.net,
        kuba@...nel.org, f.fainelli@...il.com, vivien.didelot@...il.com,
        lkp@...el.com
Subject: Re: [PATCH net-next v17 2/4] net: dsa: mv88e6xxx: wrap
 .set_egress_port method

On Wed, Mar 17, 2021 at 03:34:33PM +0100, Marek Behún wrote:
> On Wed, 17 Mar 2021 16:22:35 +0200
> Vladimir Oltean <olteanv@...il.com> wrote:
> 
> > On Wed, Mar 17, 2021 at 02:46:41PM +0100, Marek Behún wrote:
> > > There are two implementations of the .set_egress_port method, and
> > > both of them, if successful, set chip->*gress_dest_port variable.
> > > 
> > > To avoid code repetition, wrap this method into
> > > mv88e6xxx_set_egress_port.
> > > 
> > > Signed-off-by: Marek Behún <kabel@...nel.org>
> > > Reviewed-by: Pavana Sharma <pavana.sharma@...i.com>
> > > ---  
> > 
> > Separately from this series, do you think you can rename the
> > "egress_port" into "monitor_port" across the driver? Seeing an
> > EGRESS_DIR_INGRESS is pretty strange.
> 
> You mean even renaming methods .set_egress_port to .set_monitor_port,
> and type
>   enum mv88e6xxx_egress_direction
> to
>   enum mv88e6xxx_monitor_direction?

Yeah, if I'm not asking for too much. I think the last thing some
hardware with closed documentation needs is a driver that obfuscates the
configuration it applies to it.