netdev - Re: [PATCH bpf-next] bpf: Simplify expression for identify bpf mem type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLB1MoqHekQa1FrjybqmA9gBHcBcaezULb=v5PgthRB6A@mail.gmail.com>
Date:   Wed, 17 Mar 2021 12:51:27 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jianlin Lv <Jianlin.Lv@....com>
Cc:     bpf <bpf@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        Simon Horman <simon.horman@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        OSS Drivers <oss-drivers@...ronome.com>,
        Linux API <linux-api@...r.kernel.org>, iecedge@...il.com
Subject: Re: [PATCH bpf-next] bpf: Simplify expression for identify bpf mem type

On Wed, Mar 17, 2021 at 5:52 AM Jianlin Lv <Jianlin.Lv@....com> wrote:
>         return BPF_CLASS(meta->insn.code);
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 2d3036e292a9..5d77675e7112 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -21,6 +21,7 @@
>  #define BPF_DW         0x18    /* double word (64-bit) */
>  #define BPF_ATOMIC     0xc0    /* atomic memory ops - op type in immediate */
>  #define BPF_XADD       0xc0    /* exclusive add - legacy name */
> +#define BPF_SIZE_MASK  0x18    /* mask of size modifier */

Pls don't add kernel internal defines to uapi.