netdev - Re: [PATCH net-next v1 2/3] net: phy: mscc: improved serdes calibration applied to VSC8584

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFO7zN9iUMelyCdD@lunn.ch>
Date:   Thu, 18 Mar 2021 21:45:00 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Bjarni Jonasson <bjarni.jonasson@...rochip.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Antoine Tenart <atenart@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Quentin Schulz <quentin.schulz@...tlin.com>,
        Michael Walle <michael@...le.cc>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        UNGLinuxDriver <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v1 2/3] net: phy: mscc: improved serdes
 calibration applied to VSC8584

On Thu, Mar 18, 2021 at 01:38:50PM +0100, Bjarni Jonasson wrote:
> -static int vsc8584_config_init(struct phy_device *phydev)
> +static int vsc8584_config_host_serdes(struct phy_device *phydev)
>  {
> -	struct vsc8531_private *vsc8531 = phydev->priv;
> -	int ret, i;
> +	int ret;
>  	u16 val;
> +	struct vsc8531_private *vsc8531 = phydev->priv;

Reverse christmass tree. 

> +static int vsc8574_config_host_serdes(struct phy_device *phydev)
> +{
> +	int ret;
> +	u16 val;
> +	struct vsc8531_private *vsc8531 = phydev->priv;

Here as well

     Andrew