netdev - [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Mar 2021 15:31:49 +0100
From:   Marek Behún <kabel@...nel.org>
To:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org
Cc:     Marek Behún <kabel@...nel.org>
Subject: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane`
to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE.

All other occurances in this function are using the `lane` variable.

It seems I forgot to change it at this one place after refactoring.

Signed-off-by: Marek Behún <kabel@...nel.org>
Fixes: de776d0d316f7 ("net: dsa: mv88e6xxx: add support for ...")
---
 drivers/net/dsa/mv88e6xxx/serdes.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index 470856bcd2f3..f96c6ece4d75 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -1285,8 +1285,7 @@ static int mv88e6393x_serdes_port_errata(struct mv88e6xxx_chip *chip, int lane)
 	 * powered up (the bit is cleared), so power it down.
 	 */
 	if (lane == MV88E6393X_PORT0_LANE) {
-		err = mv88e6390_serdes_read(chip, MV88E6393X_PORT0_LANE,
-					    MDIO_MMD_PHYXS,
+		err = mv88e6390_serdes_read(chip, lane, MDIO_MMD_PHYXS,
 					    MV88E6393X_SERDES_POC, &reg);
 		if (err)
 			return err;
-- 
2.26.2