| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Mar 2021 01:11:56 +0800
From: kernel test robot <lkp@...el.com>
To: Eric Dumazet <eric.dumazet@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
netdev <netdev@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] net: add CONFIG_PCPU_DEV_REFCNT
Hi Eric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-add-CONFIG_PCPU_DEV_REFCNT/20210319-230417
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 38cb57602369cf194556460a52bd18e53c76e13d
config: arm-randconfig-r014-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project fcc1ce00931751ac02498986feb37744e9ace8de)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/684c34243e0c84e496aa426734df321b7ebc088b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eric-Dumazet/net-add-CONFIG_PCPU_DEV_REFCNT/20210319-230417
git checkout 684c34243e0c84e496aa426734df321b7ebc088b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> net/core/dev.c:10752:1: warning: unused label 'free_dev' [-Wunused-label]
free_dev:
^~~~~~~~~
net/core/dev.c:4993:1: warning: unused function 'sch_handle_ingress' [-Wunused-function]
sch_handle_ingress(struct sk_buff *skb, struct packet_type **pt_prev, int *ret,
^
net/core/dev.c:5143:19: warning: unused function 'nf_ingress' [-Wunused-function]
static inline int nf_ingress(struct sk_buff *skb, struct packet_type **pt_prev,
^
3 warnings generated.
vim +/free_dev +10752 net/core/dev.c
8d3bdbd55a7e2a David S. Miller 2011-02-08 10703
8d3bdbd55a7e2a David S. Miller 2011-02-08 10704 INIT_LIST_HEAD(&dev->napi_list);
8d3bdbd55a7e2a David S. Miller 2011-02-08 10705 INIT_LIST_HEAD(&dev->unreg_list);
5cde282938915f Eric W. Biederman 2013-10-05 10706 INIT_LIST_HEAD(&dev->close_list);
8d3bdbd55a7e2a David S. Miller 2011-02-08 10707 INIT_LIST_HEAD(&dev->link_watch_list);
2f268f129c2d1a Veaceslav Falico 2013-09-25 10708 INIT_LIST_HEAD(&dev->adj_list.upper);
2f268f129c2d1a Veaceslav Falico 2013-09-25 10709 INIT_LIST_HEAD(&dev->adj_list.lower);
7866a621043fba Salam Noureddine 2015-01-27 10710 INIT_LIST_HEAD(&dev->ptype_all);
7866a621043fba Salam Noureddine 2015-01-27 10711 INIT_LIST_HEAD(&dev->ptype_specific);
93642e14bd50e5 Jiri Pirko 2020-01-25 10712 INIT_LIST_HEAD(&dev->net_notifier_list);
59cc1f61f09c26 Jiri Kosina 2016-08-10 10713 #ifdef CONFIG_NET_SCHED
59cc1f61f09c26 Jiri Kosina 2016-08-10 10714 hash_init(dev->qdisc_hash);
59cc1f61f09c26 Jiri Kosina 2016-08-10 10715 #endif
0287587884b150 Eric Dumazet 2014-10-05 10716 dev->priv_flags = IFF_XMIT_DST_RELEASE | IFF_XMIT_DST_RELEASE_PERM;
8d3bdbd55a7e2a David S. Miller 2011-02-08 10717 setup(dev);
8d3bdbd55a7e2a David S. Miller 2011-02-08 10718
a813104d923339 Phil Sutter 2016-02-17 10719 if (!dev->tx_queue_len) {
f84bb1eac02752 Phil Sutter 2015-08-27 10720 dev->priv_flags |= IFF_NO_QUEUE;
1159708432f706 Jesper Dangaard Brouer 2016-11-03 10721 dev->tx_queue_len = DEFAULT_TX_QUEUE_LEN;
a813104d923339 Phil Sutter 2016-02-17 10722 }
906470c19da771 Phil Sutter 2015-08-18 10723
36909ea43814cb Tom Herbert 2011-01-09 10724 dev->num_tx_queues = txqs;
36909ea43814cb Tom Herbert 2011-01-09 10725 dev->real_num_tx_queues = txqs;
ed9af2e839c06c Tom Herbert 2010-11-09 10726 if (netif_alloc_netdev_queues(dev))
8d3bdbd55a7e2a David S. Miller 2011-02-08 10727 goto free_all;
e8a0464cc95097 David S. Miller 2008-07-17 10728
36909ea43814cb Tom Herbert 2011-01-09 10729 dev->num_rx_queues = rxqs;
36909ea43814cb Tom Herbert 2011-01-09 10730 dev->real_num_rx_queues = rxqs;
fe8222406c8277 Tom Herbert 2010-11-09 10731 if (netif_alloc_rx_queues(dev))
8d3bdbd55a7e2a David S. Miller 2011-02-08 10732 goto free_all;
0a9627f2649a02 Tom Herbert 2010-03-16 10733
^1da177e4c3f41 Linus Torvalds 2005-04-16 10734 strcpy(dev->name, name);
c835a677331495 Tom Gundersen 2014-07-14 10735 dev->name_assign_type = name_assign_type;
cbda10fa97d72c Vlad Dogaru 2011-01-13 10736 dev->group = INIT_NETDEV_GROUP;
2c60db037034d2 Eric Dumazet 2012-09-16 10737 if (!dev->ethtool_ops)
2c60db037034d2 Eric Dumazet 2012-09-16 10738 dev->ethtool_ops = &default_ethtool_ops;
e687ad60af0901 Pablo Neira 2015-05-13 10739
357b6cc5834eab Daniel Borkmann 2020-03-18 10740 nf_hook_ingress_init(dev);
e687ad60af0901 Pablo Neira 2015-05-13 10741
^1da177e4c3f41 Linus Torvalds 2005-04-16 10742 return dev;
ab9c73ccb52f40 Jiri Pirko 2009-05-08 10743
8d3bdbd55a7e2a David S. Miller 2011-02-08 10744 free_all:
8d3bdbd55a7e2a David S. Miller 2011-02-08 10745 free_netdev(dev);
8d3bdbd55a7e2a David S. Miller 2011-02-08 10746 return NULL;
8d3bdbd55a7e2a David S. Miller 2011-02-08 10747
29b4433d991c88 Eric Dumazet 2010-10-11 10748 free_pcpu:
684c34243e0c84 Eric Dumazet 2021-03-19 10749 #ifdef CONFIG_PCPU_DEV_REFCNT
29b4433d991c88 Eric Dumazet 2010-10-11 10750 free_percpu(dev->pcpu_refcnt);
684c34243e0c84 Eric Dumazet 2021-03-19 10751 #endif
74d332c13b2148 Eric Dumazet 2013-10-30 @10752 free_dev:
74d332c13b2148 Eric Dumazet 2013-10-30 10753 netdev_freemem(dev);
ab9c73ccb52f40 Jiri Pirko 2009-05-08 10754 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 10755 }
36909ea43814cb Tom Herbert 2011-01-09 10756 EXPORT_SYMBOL(alloc_netdev_mqs);
^1da177e4c3f41 Linus Torvalds 2005-04-16 10757
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (29676 bytes)
Powered by blists - more mailing lists