netdev - Re: [PATCH v4 bpf-next 07/12] libbpf: add BPF static linker BTF and BTF.ext support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFT0Q+mVbTEI1rem@krava>
Date:   Fri, 19 Mar 2021 19:58:11 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v4 bpf-next 07/12] libbpf: add BPF static linker BTF and
 BTF.ext support

On Fri, Mar 19, 2021 at 11:39:01AM -0700, Andrii Nakryiko wrote:
> On Fri, Mar 19, 2021 at 9:23 AM Jiri Olsa <jolsa@...hat.com> wrote:
> >
> > On Thu, Mar 18, 2021 at 12:40:31PM -0700, Andrii Nakryiko wrote:
> >
> > SNIP
> >
> > > +
> > > +     return NULL;
> > > +}
> > > +
> > > +static int linker_fixup_btf(struct src_obj *obj)
> > > +{
> > > +     const char *sec_name;
> > > +     struct src_sec *sec;
> > > +     int i, j, n, m;
> > > +
> > > +     n = btf__get_nr_types(obj->btf);
> >
> > hi,
> > I'm getting bpftool crash when building tests,
> >
> > looks like above obj->btf can be NULL:
> 
> I lost if (!obj->btf) return 0; somewhere along the rebases. I'll send
> a fix shortly. But how did you end up with selftests BPF objects built
> without BTF?

no idea.. I haven't even updated llvm for almost 3 days now ;-)

jirka