netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Mar 2021 20:47:32 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

On Fri, 19 Mar 2021 20:58:20 +0200
Vladimir Oltean <olteanv@...il.com> wrote:

> On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote:
> > We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane`
> > to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE.
> > 
> > All other occurances in this function are using the `lane` variable.
> > 
> > It seems I forgot to change it at this one place after refactoring.
> > 
> > Signed-off-by: Marek Behún <kabel@...nel.org>
> > Fixes: de776d0d316f7 ("net: dsa: mv88e6xxx: add support for ...")
> > ---  
> 
> Either do the Fixes tag according to the documented convention:
> git show de776d0d316f7 --pretty=fixes

THX, did not know about this.

> Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")
>
> or even better, drop it.

Why better to drop it?