netdev - Re: [PATCH bpf-next 14/15] bpf: selftest: bpf_cubic and bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbiCx=5arwSZJEiwGuAKtu2JhOG+H=WObM++3VvEef+_A@mail.gmail.com>
Date:   Thu, 18 Mar 2021 21:15:41 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next 14/15] bpf: selftest: bpf_cubic and bpf_dctcp
 calling kernel functions

On Tue, Mar 16, 2021 at 12:02 AM Martin KaFai Lau <kafai@...com> wrote:
>
> This patch removes the bpf implementation of tcp_slow_start()
> and tcp_cong_avoid_ai().  Instead, it directly uses the kernel
> implementation.
>
> It also replaces the bpf_cubic_undo_cwnd implementation by directly
> calling tcp_reno_undo_cwnd().  bpf_dctcp also directly calls
> tcp_reno_cong_avoid() instead.
>
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---

This is awesome.

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  tools/testing/selftests/bpf/bpf_tcp_helpers.h | 29 ++-----------------
>  tools/testing/selftests/bpf/progs/bpf_cubic.c |  6 ++--
>  tools/testing/selftests/bpf/progs/bpf_dctcp.c | 22 ++++----------
>  3 files changed, 11 insertions(+), 46 deletions(-)
>

[...]