netdev - Re: [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h7l6kqo7.fsf@kmk-computers.de>
Date:   Sat, 20 Mar 2021 12:31:04 +0100
From:   Kurt Kanzenbach <kurt@...-computers.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB
 region

On Sun Mar 14 2021, Kurt Kanzenbach wrote:
> On Sat Mar 13 2021, Vladimir Oltean wrote:
>> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:
>>> Allow to dump the FDB table via devlink. This is a useful debugging feature.
>>> 
>>> Signed-off-by: Kurt Kanzenbach <kurt@...-computers.de>
>>> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>>> ---
>>
>> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
>>
>> By the way, what user space program do you use to dump these? Did you
>> derive something from Andrew's mv88e6xxx_dump too? Maybe we should work
>> on something common?
>
> Actually there is no user space tooling, yet. My original approach to
> debugging was different using debugfs and tracing. I played a bit with
> mv88e6xxx_dump today. Having a common tool would be quite nice.

Thanks for the pointer to mv88e6xxx_dump. Just needed to implement
.devlink_info_get() callback, so that the tool can distinguish between
the Marvell and Hellcreek devices (and implement some hellcreek
specifics).

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (866 bytes)