netdev - Re: [PATCH net-next] net: dsa: hellcreek: Report switch name and ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFYFLiwnXBeXhqgj@lunn.ch>
Date:   Sat, 20 Mar 2021 15:22:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Kurt Kanzenbach <kurt@...-computers.de>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: hellcreek: Report switch name and ID

> +static int hellcreek_devlink_info_get(struct dsa_switch *ds,
> +				      struct devlink_info_req *req,
> +				      struct netlink_ext_ack *extack)
> +{
> +	struct hellcreek *hellcreek = ds->priv;
> +	int ret;
> +
> +	ret = devlink_info_driver_name_put(req, "hellcreek");
> +	if (ret)
> +		return ret;
> +
> +	return devlink_info_version_fixed_put(req,
> +					      DEVLINK_INFO_VERSION_GENERIC_ASIC_ID,
> +					      hellcreek->pdata->name);

>  static const struct hellcreek_platform_data de1soc_r1_pdata = {
> +	.name		 = "Hellcreek r4c30",

Hi Kurt

The two other DSA drivers which implement this keep the
DEVLINK_INFO_VERSION_GENERIC_ASIC_ID just the model name, mv88e6390,
SJA1105E for example. You have hellcreek in the driver name, so i
don't see a need to repeat it.

      Andrew