netdev - Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Mar 2021 13:56:26 +0100 (CET)
From:   Justin Iurman <justin.iurman@...ege.be>
To:     kernel test robot <rong.a.chen@...el.com>
Cc:     netdev@...r.kernel.org, kbuild-all@...ts.01.org,
        davem@...emloft.net, kuba@...nel.org, tom@...bertland.com
Subject: Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection
 with lwtunnels


> Hi Justin,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on net-next/master]
> 
> url:
> https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> d310ec03a34e92a77302edb804f7d68ee4f01ba0
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
> config: sparc64-randconfig-s032-20210310 (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 9.3.0
> reproduce:
>        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
>        ~/bin/make.cross
>        chmod +x ~/bin/make.cross
>        # apt-get install sparse
>        # sparse version: v0.6.3-262-g5e674421-dirty
>        #
>        https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
>        git remote add linux-review https://github.com/0day-ci/linux
>        git fetch --no-tags linux-review
>        Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
>        git checkout f20771586508a195a44298f251d68446c10830ce
>        # save the attached .config to linux build tree
>        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
>        CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> 
> "sparse warnings: (new ones prefixed by >>)"
>>> net/ipv6/ioam6.c:856:1: sparse: sparse: unused label 'out_unregister_genl'

Apologies for this small oversight, will update it and post a v3 (forgot the "v2" tag for this patchset by the way).

> vim +/out_unregister_genl +856 net/ipv6/ioam6.c
> 
> f20771586508a1 Justin Iurman 2021-03-10  851
> e1a4cb7c14f537 Justin Iurman 2021-03-10  852  	pr_info("In-situ OAM (IOAM) with
> IPv6\n");
> ffece959dfe59a Justin Iurman 2021-03-10  853
> ffece959dfe59a Justin Iurman 2021-03-10  854  out:
> ffece959dfe59a Justin Iurman 2021-03-10  855  	return err;
> f20771586508a1 Justin Iurman 2021-03-10 @856  out_unregister_genl:
> f20771586508a1 Justin Iurman 2021-03-10  857
> 	genl_unregister_family(&ioam6_genl_family);
> ffece959dfe59a Justin Iurman 2021-03-10  858  out_unregister_pernet_subsys:
> ffece959dfe59a Justin Iurman 2021-03-10  859
> 	unregister_pernet_subsys(&ioam6_net_ops);
> ffece959dfe59a Justin Iurman 2021-03-10  860  	goto out;
> e1a4cb7c14f537 Justin Iurman 2021-03-10  861  }
> e1a4cb7c14f537 Justin Iurman 2021-03-10  862