netdev - Re: [PATCH net-next] [v2] misdn: avoid -Wempty-body warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Mar 2021 15:58:30 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     netdev@...r.kernel.org, Karsten Keil <isdn@...ux-pingi.de>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] [v2] misdn: avoid -Wempty-body warning

On Mon, Mar 22, 2021 at 01:14:47PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> gcc warns about a pointless condition:
> 
> drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt':
> drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>  2752 |                 ; /* external IRQ */
> 
> As the check has no effect, just remove it.
> 
> Suggested-by: Leon Romanovsky <leon@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2: remove the line instead of adding {}
> ---
>  drivers/isdn/hardware/mISDN/hfcmulti.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Thanks, interesting when we will delete whole drivers/isdn :)

Reviewed-by: Leon Romanovsky <leonro@...dia.com>