netdev - Re: [PATCH net-next] net: set initial device refcount to 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210322.165833.254193305389397663.davem@davemloft.net>
Date:   Mon, 22 Mar 2021 16:58:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, edumazet@...gle.com,
        groeck@...gle.com
Subject: Re: [PATCH net-next] net: set initial device refcount to 1

From: David Miller <davem@...emloft.net>
Date: Mon, 22 Mar 2021 16:55:26 -0700 (PDT)

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 22 Mar 2021 11:21:45 -0700
> 
> This hunk:
>> @@ -10682,6 +10682,9 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name,
>>  	dev->pcpu_refcnt = alloc_percpu(int);
>>  	if (!dev->pcpu_refcnt)
>>  		goto free_dev;
>> +	dev_hold(dev);
>> +#else
>> +	refcount_set(&dev->dev_refcnt, 1);
>>  #endif
>>  
>>  	if (dev_addr_init(dev))
>  gets rejects in net-next.  Please respin.
>  

My bad, I was trying to apply it to 'net' mistakedly.

All good now, thanks.