netdev - Re: [Intel-wired-lan] [PATCH net-next] e1000e: Mark e1000e_pm_prepare() as __maybe_unused

Open Source and information security mailing list archives

Message-ID: <80dcead2-f0e1-c1a4-037c-6215f960f32f@intel.com>
Date:   Mon, 22 Mar 2021 08:56:17 +0200
From:   "Neftin, Sasha" <sasha.neftin@...el.com>
To:     'w00385741 <weiyongjun1@...wei.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        Jakub Kicinski <kuba@...nel.org>, Chen Yu <yu.c.chen@...el.com>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, Hulk Robot <hulkci@...wei.com>,
        "Neftin, Sasha" <sasha.neftin@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next] e1000e: Mark
 e1000e_pm_prepare() as __maybe_unused

On 3/17/2021 16:52, 'w00385741 wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> The function e1000e_pm_prepare() may have no callers depending
> on configuration, so it must be marked __maybe_unused to avoid
> harmless warning:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:6926:12:
>   warning: 'e1000e_pm_prepare' defined but not used [-Wunused-function]
>   6926 | static int e1000e_pm_prepare(struct device *dev)
>        |            ^~~~~~~~~~~~~~~~~
> 
> Fixes: ccf8b940e5fd ("e1000e: Leverage direct_complete to speed up s2ram")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Sasha Neftin <sasha.neftin@...el.com>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index f1c9debd9f3b..d2e4653536c5 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -6923,7 +6923,7 @@ static int __e1000_resume(struct pci_dev *pdev)
>   	return 0;
>   }
>   
> -static int e1000e_pm_prepare(struct device *dev)
> +static __maybe_unused int e1000e_pm_prepare(struct device *dev)
>   {
>   	return pm_runtime_suspended(dev) &&
>   		pm_suspend_via_firmware();
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives