netdev - Re: [PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cf00a0a-c97e-2bd5-5091-3acca0733655@nvidia.com>
Date:   Mon, 22 Mar 2021 12:42:55 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Roopa Prabhu <roopa@...dia.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup
 argument tunnel_id as __be64

On 22/03/2021 12:38, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The only caller of br_vlan_tunnel_lookup, br_handle_ingress_vlan_tunnel,
> extracts the tunnel_id from struct ip_tunnel_info::struct ip_tunnel_key::
> tun_id which is a __be64 value.
> 
> The exact endianness does not seem to matter, because the tunnel id is
> just used as a lookup key for the VLAN group's tunnel hash table, and
> the value is not interpreted directly per se. Moreover,
> rhashtable_lookup_fast treats the key argument as a const void *.
> 
> Therefore, there is no functional change associated with this patch,
> just one to silence "make W=1" builds.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  net/bridge/br_vlan_tunnel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c
> index 169e005fbda2..0d3a8c01552e 100644
> --- a/net/bridge/br_vlan_tunnel.c
> +++ b/net/bridge/br_vlan_tunnel.c
> @@ -35,7 +35,7 @@ static const struct rhashtable_params br_vlan_tunnel_rht_params = {
>  };
>  
>  static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl,
> -						     u64 tunnel_id)
> +						     __be64 tunnel_id)
>  {
>  	return rhashtable_lookup_fast(tbl, &tunnel_id,
>  				      br_vlan_tunnel_rht_params);
> 

Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>