netdev - Re: [Patch bpf-next v6 02/12] skmsg: introduce a spinlock to protect ingress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXoWmk2anOHmVJH0z+ih3mcEY8ghid+OjsZPAGbL0qKqQ@mail.gmail.com>
Date:   Mon, 22 Mar 2021 20:38:05 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Lorenz Bauer <lmb@...udflare.com>,
        Jakub Sitnicki <jakub@...udflare.com>
Subject: Re: [Patch bpf-next v6 02/12] skmsg: introduce a spinlock to protect ingress_msg

On Mon, Mar 22, 2021 at 6:25 PM Yunsheng Lin <linyunsheng@...wei.com> wrote:
>
> On 2021/3/23 8:37, Cong Wang wrote:
> > +static inline struct sk_msg *sk_psock_next_msg(struct sk_psock *psock,
> > +                                            struct sk_msg *msg)
> > +{
> > +     struct sk_msg *ret;
>
> Nit:
> Use msg instead of ret to be consistently with sk_psock_dequeue_msg()
> and sk_psock_next_msg().

Please read it carefully, clearly 'msg' is already a parameter name here.

Thanks.