netdev - Re: [PATCH ipsec] esp: delete NETIF_F_SCTP_CRC bit from features for esp offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210323081446.GN62598@gauss3.secunet.de>
Date:   Tue, 23 Mar 2021 09:14:46 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <linux-sctp@...r.kernel.org>, <netdev@...r.kernel.org>,
        "Marcelo Ricardo Leitner" <marcelo.leitner@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH ipsec] esp: delete NETIF_F_SCTP_CRC bit from features for
 esp offload

On Fri, Mar 19, 2021 at 03:35:07PM +0800, Xin Long wrote:
> Now in esp4/6_gso_segment(), before calling inner proto .gso_segment,
> NETIF_F_CSUM_MASK bits are deleted, as HW won't be able to do the
> csum for inner proto due to the packet encrypted already.
> 
> So the UDP/TCP packet has to do the checksum on its own .gso_segment.
> But SCTP is using CRC checksum, and for that NETIF_F_SCTP_CRC should
> be deleted to make SCTP do the csum in own .gso_segment as well.
> 
> In Xiumei's testing with SCTP over IPsec/veth, the packets are kept
> dropping due to the wrong CRC checksum.
> 
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Fixes: 7862b4058b9f ("esp: Add gso handlers for esp4 and esp6")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks Xin!