netdev - Re: [PATCH v2 22/23] RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Mar 2021 11:54:58 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Shiraz Saleem <shiraz.saleem@...el.com>, dledford@...hat.com,
        jgg@...dia.com, kuba@...nel.org, davem@...emloft.net
Cc:     linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        david.m.ertman@...el.com, anthony.l.nguyen@...el.com
Subject: Re: [PATCH v2 22/23] RDMA/irdma: Add irdma Kconfig/Makefile and
 remove i40iw

On 3/23/21 5:00 PM, Shiraz Saleem wrote:
> diff --git a/drivers/infiniband/hw/irdma/Kconfig b/drivers/infiniband/hw/irdma/Kconfig
> new file mode 100644
> index 00000000..6585842
> --- /dev/null
> +++ b/drivers/infiniband/hw/irdma/Kconfig
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config INFINIBAND_IRDMA
> +	tristate "Intel(R) Ethernet Protocol Driver for RDMA"
> +	depends on INET
> +	depends on IPV6 || !IPV6
> +	depends on PCI
> +	select GENERIC_ALLOCATOR
> +	select CONFIG_AUXILIARY_BUS
> +	help
> +	 This is an Intel(R) Ethernet Protocol Driver for RDMA driver
> +	 that support E810 (iWARP/RoCE) and X722 (iWARP) network devices.


<pseudo bot>

Please follow coding-style for Kconfig files:

from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


thanks.
-- 
~Randy