netdev - RE: [PATCH v2 05/23] ice: Add devlink params support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB43228B823CA619460AAF2099DC639@BY5PR12MB4322.namprd12.prod.outlook.com>
Date:   Wed, 24 Mar 2021 04:50:51 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Shiraz Saleem <shiraz.saleem@...el.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "david.m.ertman@...el.com" <david.m.ertman@...el.com>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>
Subject: RE: [PATCH v2 05/23] ice: Add devlink params support

Hi Shiraz,

> From: Shiraz Saleem <shiraz.saleem@...el.com>
> Sent: Wednesday, March 24, 2021 5:30 AM
> 
> Add two new runtime RDMA related devlink parameters to ice driver.
> 'rdma_resource_limits_sel' is driver-specific while 'rdma_protocol' is generic.
> Configuration changes result in unplugging the auxiliary RDMA device and re-
> plugging it with updated values for irdma auxiiary driver to consume at
> drv.probe()
> 
> Signed-off-by: Shiraz Saleem <shiraz.saleem@...el.com>
> ---
>  .../networking/devlink/devlink-params.rst          |   6 +
>  Documentation/networking/devlink/ice.rst           |  35 +++++
>  drivers/net/ethernet/intel/ice/ice_devlink.c       | 146
> ++++++++++++++++++++-
>  drivers/net/ethernet/intel/ice/ice_devlink.h       |   6 +
>  drivers/net/ethernet/intel/ice/ice_main.c          |   2 +
>  include/net/devlink.h                              |   4 +
>  net/core/devlink.c                                 |   5 +
>  7 files changed, 202 insertions(+), 2 deletions(-)
> 

[..]
> +.. list-table:: Driver-specific parameters implemented
> +   :widths: 5 5 5 85
> +
> +   * - Name
> +     - Type
> +     - Mode
> +     - Description
> +   * - ``rdma_resource_limits_sel``
> +     - string
> +     - runtime
> +     - Selector to limit the RDMA resources configured for the device. The
> range
> +       is between 0 and 7 with a default value equal to 3. Each selector
> supports
> +       up to the value specified in the table.
> +          - 0: 128 QPs
> +          - 1: 1K QPs
> +          - 2: 2K QPs
> +          - 3: 4K QPs
> +          - 4: 16K QPs
> +          - 5: 64K QPs
> +          - 6: 128K QPs
> +          - 7: 256K QPs

Resources are better represented as devlink resource.
Such as,

$ devlink resource set pci/0000:06:00.0 /rdma/max_qps 16384
$ devlink resource set pci/0000:06:00.0 /rdma/max_cqs 8192
$ devlink resource set pci/0000:06:00.0 /rdma/max_mrs 16384

Please move from param to resource.