netdev - Re: [PATCH net-next v3 2/2] net: pcs: configure xpcs 2.5G speed mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210325085902.GK1463@shell.armlinux.org.uk>
Date:   Thu, 25 Mar 2021 08:59:03 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net, kuba@...nel.org,
        mcoquelin.stm32@...il.com, weifeng.voon@...el.com,
        boon.leong.ong@...el.com, qiangqing.zhang@....com,
        vee.khee.wong@...el.com, fugang.duan@....com,
        kim.tatt.chuah@...el.com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        andrew@...n.ch, hkallweit1@...il.com
Subject: Re: [PATCH net-next v3 2/2] net: pcs: configure xpcs 2.5G speed mode

On Thu, Mar 25, 2021 at 04:38:06PM +0800, Michael Sit Wei Hong wrote:
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 12a047d47dec..c95dfe4e5310 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -290,6 +290,8 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
>  
>  		switch (pl->link_config.interface) {
>  		case PHY_INTERFACE_MODE_SGMII:
> +			phylink_set(pl->supported, 2500baseT_Full);
> +			fallthrough;

This is wrong. "SGMII" here means 1G SGMII. See the documentation in
Documentation/networking/phy.rst.

If we want to have this at 2.5G speed, then we need a separate
enumeration for that mode, just like we make a distinction between
1000BASE-X and 2500BASE-X.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!