netdev - Re: [PATCHv1 0/6] Amlogic Soc - Add missing ethernet mdio compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 21:10:10 +0530
From:   Anand Moon <linux.amoon@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>, Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        netdev@...r.kernel.org, devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCHv1 0/6] Amlogic Soc - Add missing ethernet mdio compatible string

Hi Heiner


On Thu, 25 Mar 2021 at 18:49, Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 25.03.2021 13:42, Anand Moon wrote:
> > On most of the Amlogic SoC I observed that Ethernet would not get
> > initialize when try to deploy the mainline kernel, earlier I tried to
> > fix this issue with by setting ethernet reset but it did not resolve
> > the issue see below.
> >       resets = <&reset RESET_ETHERNET>;
> >       reset-names = "stmmaceth";
> >
> > After checking what was the missing with Rockchip SoC dts
> > I tried to add this missing compatible string and then it
> > started to working on my setup.
> >
> > Also I tried to fix the device tree binding to validate the changes.
> >
> > Tested this on my Odroid-N2 and Odroid-C2 (64 bit) setup.
> > I do not have ready Odroid C1 (32 bit) setup so please somebody test.
> >
>
> When working on the Odroid-C2 I did not have such a problem.
> And if you look at of_mdiobus_child_is_phy() and
> of_mdiobus_register_phy() you'll see that your change shouldn't be
> needed.
I will check this out, thanks for your inputs.
>
> Could you please elaborate on:
> - What is the exact problem you're facing? Best add a dmesg log.
   1> I am aware all the distro kernel I have tested ethernet will work file
   2> My issue is when I compile the mainline kernel with the default setting,
       Ethernet interface will not receive any DHCP IP address from the router
       Although the Ethernet interface comes up properly.
      This does not happen frequently but I observed this at my end.
  3> I tried to collect logs but I did not observe any kernel issue
like panic or warning.

> - Which kernel version are you using?
     I am using the mainline kernel with default settings.

-Anand