netdev - Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFy2fnV7GQLOKkRy@carbon>
Date:   Thu, 25 Mar 2021 18:12:46 +0200
From:   Petko Manolov <petkan@...leusys.com>
To:     'Qiheng Lin <linqiheng@...wei.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include
 from pegasus.c

On 21-03-25 22:56:52, 'Qiheng Lin wrote:
> From: Qiheng Lin <linqiheng@...wei.com>
> 
> Remove duplicated include.

It is not duplicated so do not remove it.  Go ahead and look carefully at the
code, please.


		Petko


> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> ---
>  drivers/net/usb/pegasus.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index 9a907182569c..e0ee5c096396 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -65,7 +65,6 @@ static struct usb_eth_dev usb_dev_id[] = {
>  	{.name = pn, .vendor = vid, .device = pid, .private = flags},
>  #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
>  	PEGASUS_DEV(pn, vid, pid, flags)
> -#include "pegasus.h"
>  #undef	PEGASUS_DEV
>  #undef	PEGASUS_DEV_CLASS
>  	{NULL, 0, 0, 0},
> @@ -84,7 +83,6 @@ static struct usb_device_id pegasus_ids[] = {
>  #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
>  	{.match_flags = (USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_DEV_CLASS), \
>  	.idVendor = vid, .idProduct = pid, .bDeviceClass = dclass},
> -#include "pegasus.h"
>  #undef	PEGASUS_DEV
>  #undef	PEGASUS_DEV_CLASS
>  	{},
> 
>