netdev - Re: [PATCH net-next] nexthop: Rename artifacts related to legacy multipath nexthop groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 09:13:54 -0600
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] nexthop: Rename artifacts related to legacy
 multipath nexthop groups

On 3/26/21 7:20 AM, Petr Machata wrote:
> After resilient next-hop groups have been added recently, there are two
> types of multipath next-hop groups: the legacy "mpath", and the new
> "resilient". Calling the legacy next-hop group type "mpath" is unfortunate,
> because that describes the fact that a packet could be forwarded in one of
> several paths, which is also true for the resilient next-hop groups.
> 
> Therefore, to make the naming clearer, rename various artifacts to reflect
> the assumptions made. Therefore as of this patch:
> 
> - The flag for multipath groups is nh_grp_entry::is_multipath. This
>   includes the legacy and resilient groups, as well as any future group
>   types that behave as multipath groups.
>   Functions that assume this have "mpath" in the name.
> 
> - The flag for legacy multipath groups is nh_grp_entry::hash_threshold.
>   Functions that assume this have "hthr" in the name.
> 
> - The flag for resilient groups is nh_grp_entry::resilient.
>   Functions that assume this have "res" in the name.
> 
> Besides the above, struct nh_grp_entry::mpath was renamed to ::hthr as
> well.
> 
> UAPI artifacts were obviously left intact.
> 
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  include/net/nexthop.h |  4 ++--
>  net/ipv4/nexthop.c    | 56 +++++++++++++++++++++----------------------
>  2 files changed, 30 insertions(+), 30 deletions(-)
> 

Thanks for the followup.

Reviewed-by: David Ahern <dsahern@...nel.org>