netdev - Re: [PATCH net-next] docs: nf_flowtable: fix compilation and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 12:04:09 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net-next] docs: nf_flowtable: fix compilation and
 warnings

Hi Pablo,

On Thu, 25 Mar 2021 22:10:16 +0100 Pablo Neira Ayuso <pablo@...filter.org> wrote:
>
> ... cannot be used in block quote, it breaks compilation, remove it.
> 
> Fix warnings due to missing blank line such as:
> 
> net-next/Documentation/networking/nf_flowtable.rst:142: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Fixes: 143490cde566 ("docs: nf_flowtable: update documentation with enhancements")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---
>  Documentation/networking/nf_flowtable.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/nf_flowtable.rst b/Documentation/networking/nf_flowtable.rst
> index d87f253b9d39..d757c21c10f2 100644
> --- a/Documentation/networking/nf_flowtable.rst
> +++ b/Documentation/networking/nf_flowtable.rst
> @@ -112,6 +112,7 @@ You can identify offloaded flows through the [OFFLOAD] tag when listing your
>  connection tracking table.
>  
>  ::
> +
>  	# conntrack -L
>  	tcp      6 src=10.141.10.2 dst=192.168.10.2 sport=52728 dport=5201 src=192.168.10.2 dst=192.168.10.1 sport=5201 dport=52728 [OFFLOAD] mark=0 use=2
>  
> @@ -138,6 +139,7 @@ allows the flowtable to define a fastpath bypass between the bridge ports
>  device (represented as eth0) in your switch/router.
>  
>  ::
> +
>                        fastpath bypass
>                 .-------------------------.
>                /                           \
> @@ -168,12 +170,12 @@ connection tracking entry by specifying the counter statement in your flowtable
>  definition, e.g.
>  
>  ::
> +
>  	table inet x {
>  		flowtable f {
>  			hook ingress priority 0; devices = { eth0, eth1 };
>  			counter
>  		}
> -		...
>  	}
>  
>  Counter support is available since Linux kernel 5.7.
> @@ -185,12 +187,12 @@ If your network device provides hardware offload support, you can turn it on by
>  means of the 'offload' flag in your flowtable definition, e.g.
>  
>  ::
> +
>  	table inet x {
>  		flowtable f {
>  			hook ingress priority 0; devices = { eth0, eth1 };
>  			flags offload;
>  		}
> -		...
>  	}
>  
>  There is a workqueue that adds the flows to the hardware. Note that a few

Thanks.

I will add this into linux-next today and will drop it when it (or
something similar) turns up in a tree.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped