netdev - RE: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24e5759118f746c18539fc5fc0b4c706@intel.com>
Date:   Mon, 29 Mar 2021 13:36:08 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Jason Gunthorpe <jgg@...dia.com>, Leon Romanovsky <leon@...nel.org>
CC:     Doug Ledford <dledford@...hat.com>, Mark Bloch <mbloch@...dia.com>,
        "Adit Ranadive" <aditr@...are.com>,
        Ariel Elior <aelior@...vell.com>,
        "Bart Van Assche" <bvanassche@....org>,
        Bernard Metzler <bmt@...ich.ibm.com>,
        Christian Benvenuti <benve@...co.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        "Latif, Faisal" <faisal.latif@...el.com>,
        "Gal Pressman" <galpress@...zon.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Lijun Ou <oulijun@...wei.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Mike Marciniszyn" <mike.marciniszyn@...nelisnetworks.com>,
        Naresh Kumar PBS <nareshkumar.pbs@...adcom.com>,
        Nelson Escobar <neescoba@...co.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Potnuri Bharat Teja <bharat@...lsio.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "VMware PV-Drivers" <pv-drivers@...are.com>,
        Weihang Li <liweihang@...wei.com>,
        "Wei Hu(Xavier)" <huwei87@...ilicon.com>,
        Yishai Hadas <yishaih@...dia.com>,
        "Zhu Yanjun" <zyjzyj2000@...il.com>
Subject: RE: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

> Subject: Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports
> 
> On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote:
> > From: Mark Bloch <mbloch@...dia.com>
> >
> > Current code uses many different types when dealing with a port of a
> > RDMA device: u8, unsigned int and u32. Switch to u32 to clean up the
> > logic.
> >
> > This allows us to make (at least) the core view consistent and use the
> > same type. Unfortunately not all places can be converted. Many uverbs
> > functions expect port to be u8 so keep those places in order not to break
> UAPIs.
> > HW/Spec defined values must also not be changed.
> >
> > With the switch to u32 we now can support devices with more than 255
> > ports. U32_MAX is reserved to make control logic a bit easier to deal
> > with. As a device with U32_MAX ports probably isn't going to happen
> > any time soon this seems like a non issue.
> >
> > When a device with more than 255 ports is created uverbs will report
> > the RDMA device as having 255 ports as this is the max currently supported.
> >
> > The verbs interface is not changed yet because the IBTA spec limits
> > the port size in too many places to be u8 and all applications that
> > relies in verbs won't be able to cope with this change. At this stage,
> > we are extending the interfaces that are using vendor channel solely
> >
> > Once the limitation is lifted mlx5 in switchdev mode will be able to
> > have thousands of SFs created by the device. As the only instance of
> > an RDMA device that reports more than 255 ports will be a representor
> > device and it exposes itself as a RAW Ethernet only device
> > CM/MAD/IPoIB and other ULPs aren't effected by this change and their
> > sysfs/interfaces that are exposes to userspace can remain unchanged.
> >
> > While here cleanup some alignment issues and remove unneeded sanity
> > checks (mainly in rdmavt),
> >
> > Signed-off-by: Mark Bloch <mbloch@...dia.com>
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > ---
> 
> Applied to for-next, I suppose this means the irdma driver needs re-spinning
> already.
> 

Sure.