netdev - RE: [PATCH net] enetc: Avoid implicit sign extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR04MB6754BD655B05D9F5B66BC6C1967E9@AM0PR04MB6754.eurprd04.prod.outlook.com>
Date:   Mon, 29 Mar 2021 13:53:09 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: RE: [PATCH net] enetc: Avoid implicit sign extension

>-----Original Message-----
>From: Claudiu Manoil <claudiu.manoil@....com>
>Sent: Monday, March 29, 2021 4:35 PM
>To: netdev@...r.kernel.org
>Cc: Jakub Kicinski <kuba@...nel.org>; David S . Miller
><davem@...emloft.net>; Vladimir Oltean <vladimir.oltean@....com>
>Subject: [PATCH net] enetc: Avoid implicit sign extension
>
>Static analysis tool reports:
>"Suspicious implicit sign extension - 'flags' with type u8 (8 bit,
>unsigned) is promoted in 'flags' << 24 to type int (32 bits, signed),
>then sign-extended to type unsigned long long (64 bits, unsigned).
>If flags << 24 is greater than 0x7FFFFFFF, the upper bits of the result
>will all be 1."
>
>Use lower_32_bits() to avoid this scenario.
>

Fixes: 82728b91f124 ("enetc: Remove Tx checksumming offload code")