netdev - Re: [PATCH 1/1] net: dsa: Fix type was not set for devlink port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e0053f3-39b6-b13b-1545-91beb5d1f49a@gmail.com>
Date:   Mon, 29 Mar 2021 09:56:32 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, Maxim Kochetkov <fido_max@...ox.ru>
Cc:     vivien.didelot@...il.com, olteanv@...il.com, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: dsa: Fix type was not set for devlink port

On 3/29/21 9:50 AM, Andrew Lunn wrote:
> On Mon, Mar 29, 2021 at 06:30:16PM +0300, Maxim Kochetkov wrote:
>> If PHY is not available on DSA port (described at devicetree but absent or
>> failed to detect) then kernel prints warning after 3700 secs:
>>
>> [ 3707.948771] ------------[ cut here ]------------
>> [ 3707.948784] Type was not set for devlink port.
>> [ 3707.948894] WARNING: CPU: 1 PID: 17 at net/core/devlink.c:8097 0xc083f9d8
>>
>> We should unregister the devlink port as a user port and
>> re-register it as an unused port before executing "continue" in case of
>> dsa_port_setup error.
>>
>> Fixes: 86f8b1c01a0a ("net: dsa: Do not make user port errors fatal")
> 
> This commit says:
> 
>     Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would
>     not treat failures to set-up an user port as fatal, but after this
>     commit we would, which is a regression for some systems where interfaces
>     may be declared in the Device Tree, but the underlying hardware may not
>     be present (pluggable daughter cards for instance).
> 
> Florian
> 
> Are these daughter cards hot pluggable? So we expect them to appear
> and the port is then usable? Or is a reboot required?

The systems need to be powered off cards replaced and then powered back
on so no true hot-pluggable scheme but cold-pluggable definitively.
-- 
Florian