netdev - Re: [PATCH rdma-next v1 5/5] net/bnxt: Use direct API instead of useless indirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANjDDBhzEg3hTR9Re7W3bvzWpNx262Vbz8ecCogZdmTRoJ_hfg@mail.gmail.com>
Date:   Mon, 29 Mar 2021 23:42:50 +0530
From:   Devesh Sharma <devesh.sharma@...adcom.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Michael Chan <michael.chan@...adcom.com>,
        Leon Romanovsky <leon@...nel.org>,
        Doug Ledford <dledford@...hat.com>,
        Leon Romanovsky <leonro@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Naresh Kumar PBS <nareshkumar.pbs@...adcom.com>,
        Netdev <netdev@...r.kernel.org>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Subject: Re: [PATCH rdma-next v1 5/5] net/bnxt: Use direct API instead of
 useless indirection

On Mon, Mar 29, 2021 at 7:46 PM Jason Gunthorpe <jgg@...dia.com> wrote:
>
> On Mon, Mar 29, 2021 at 07:01:44AM -0700, Michael Chan wrote:
> > On Mon, Mar 29, 2021 at 1:52 AM Leon Romanovsky <leon@...nel.org> wrote:
> > >
> > > From: Leon Romanovsky <leonro@...dia.com>
> > >
> > > There is no need in any indirection complexity for one ULP user,
> > > remove all this complexity in favour of direct calls to the exported
> > > symbols. This allows us to greatly simplify the code.
> >
> > The goal is not to have a hard dependency between the RDMA driver and
> > the ethernet driver.  One day, there may be a newer ethernet driver
> > for newer devices.  The RDMA driver may be the same because it
> > operates at a higher level.  The hard dependency will require the
> > older ethernet driver to always be loaded even if it is not needed.
>
> Then someday you will fix it. Today you do not have this, so it needs
> to be deleted.
>
> If you ever get to that point you will need to rework this driver to
> use auxillary bus/etc, and it will look very different anyhow.
>
> Jason
Hello Jason and Leon,

Thanks for the series, we will get back with an ACK on this series
after internal discussion to see if all the cases are covered and our
internal test harness is passing with these changes.


-- 
-Regards
Devesh

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)