netdev - Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Mar 2021 14:42:18 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Andreas Roeseler <andreas.a.roeseler@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

On Mon, Mar 29, 2021 at 2:34 PM Andreas Roeseler
<andreas.a.roeseler@...il.com> wrote:
>
> On Sun, 2021-03-28 at 13:00 -0400, Willem de Bruijn wrote:
> > On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler
> > <andreas.a.roeseler@...il.com> wrote:
> > >
> >
> > > +       if (!ext_hdr || !iio)
> > > +               goto send_mal_query;
> > > +       if (ntohs(iio->extobj_hdr.length) <= sizeof(iio-
> > > >extobj_hdr))
> > > +               goto send_mal_query;
> > > +       ident_len = ntohs(iio->extobj_hdr.length) - sizeof(iio-
> > > >extobj_hdr);
> >
> > As asked in v3: this can have negative overflow?
>
> The line above checks that iio->extobj_hdr.length is greater than the
> size of iio->extobj_hdr.

Completely missed that, clearly. Thanks, that's great, then.